disable LTO in RISC-V to speed up build #1038
Merged
+32
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After doing some emulated, local tests, I think this seems reasonable to try again. It'll be a less optimized python, but that's better than no riscv64 None of these builds are as slow as I was getting in #931 and it's on the same machine. 😕 🤷 $ # --with-lto
$ for ver in 3.10 3.11 3.12; do time docker build --no-cache --platform linux/riscv64 ./$ver/alpine3.20/; done
real 19m13.374s
real 30m32.618s
real 33m12.560s
$ # without lto
$ for ver in 3.10 3.11 3.12; do time docker build --no-cache --platform linux/riscv64 ./$ver/alpine3.20/; done
real 8m49.526s
real 9m41.161s
real 9m22.683sRequested change: also remove this part of |
tianon
reviewed
May 8, 2025
| @@ -182,7 +182,7 @@ RUN set -eux; \ | |||
| # <3.10 does not have -fno-semantic-interposition enabled and --with-lto does nothing for performance | |||
There was a problem hiding this comment.
Suggested change
| # <3.10 does not have -fno-semantic-interposition enabled and --with-lto does nothing for performance | |
| # <3.10 does not have -fno-semantic-interposition enabled and --with-lto does nothing for performance | |
| # skip LTO on alpine on riscv64: https://github.com/docker-library/python/pull/935, https://github.com/docker-library/python/pull/1038 |
|
thanks for the comments, should all be done |
tianon
approved these changes
May 8, 2025
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
May 9, 2025
Changes: - docker-library/python@4c3ad300: Merge pull request docker-library/python#1038 from mmoll/no_lto_on_riscv - docker-library/python@90aa4272: disable LTO in RISC-V to speed up build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1011