-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Revert "dpkg-divert" and change PATH instead #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "dpkg-divert" and change PATH instead #137
Conversation
- this reverts commit a819c92. - since Debian packages use an absolute path, they were broken by the diverts - ensure the local python is first in PATH
FWIW, these images already have |
@JayH5 indeed, the point is to be 100% explicit to ensure that by default, LGTM |
- `docker`: `${DOCKER_VERSION}` (cosmetic; docker-library/docker#16) - `java`: Debian 9~b130 - `php`: note that `Dockerfile`s are generated (docker-library/php@e36077f) - `python`: use `PATH` instead of `dpkg-divert` or `purge` (docker-library/python#137) - `rocket.chat`: 0.36.0
Would it make sense to add automated tests for this issue? Python is one of the most popular images: an issue like this has a fairly large impact. |
@darabos, that sounds like a great idea. Do you have an idea of what would be the best indicator? Maybe just test that We do have tests that we run from travis that are also part of accepting it into official-images for building and pushing to the hub: https://github.com/docker-library/official-images/tree/master/test. |
Sorry, I'm just a clueless user with no deep understanding of the issue. We just experienced that Thanks for the link, I never knew about those tests! It looks like Just testing |
Reverting and changing #131 which was the fix for #129. Also fix some spaces to tabs like the rest of the file.
Fix #133, fix #134.