3.6/alpine3.7: Build nis module now that 3.6.5 is patched #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
reviewed
Mar 30, 2018
| @@ -160,8 +160,7 @@ for version in "${versions[@]}"; do | |||
|
|
|||
| # Libraries to build the nis module available in Alpine 3.7, but also require this patch: | |||
| # https://bugs.python.org/issue32521 | |||
| # TODO: Remove Python version check once 2.7 and 3.6 have the patch | |||
| if [[ "$variant" == alpine* ]] && [[ "$variant" != alpine3.7 || "$version" != 3.7* ]]; then | |||
| if [[ "$variant" == alpine* ]] && [[ "$variant" != alpine3.7 ]]; then | |||
There was a problem hiding this comment.
Won't this also leave the libraries on python:2.7-alpine3.7? Is that version fixed too?
There was a problem hiding this comment.
I did think so when I wrote this the first time, but the Python 2.7 Dockerfiles actually aren’t templated.
There was a problem hiding this comment.
You are correct; I forgot about these lines
Lines 135 to 136 in 33b16b4
yosifkit
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Apr 3, 2018
- `docker` update to `18.04.0-ce-rc1` - `ghost` update to `1.22.1` - `golang` docker-library/golang#215 - `openjdk` minor Debian openjdk bumps - `php` bump to `7.2.4`, `7.1.16`, `7.0.29`, and `5.6.35` - `python` docker-library/python#274 - `tomcat` openssl `1.1.0f-3+deb9u2`
davidl-zend
pushed a commit
to davidl-zend/official-images
that referenced
this pull request
Apr 17, 2018
- `docker` update to `18.04.0-ce-rc1` - `ghost` update to `1.22.1` - `golang` docker-library/golang#215 - `openjdk` minor Debian openjdk bumps - `php` bump to `7.2.4`, `7.1.16`, `7.0.29`, and `5.6.35` - `python` docker-library/python#274 - `tomcat` openssl `1.1.0f-3+deb9u2`
davidl-zend
pushed a commit
to davidl-zend/official-images
that referenced
this pull request
Apr 17, 2018
- `docker` update to `18.04.0-ce-rc1` - `ghost` update to `1.22.1` - `golang` docker-library/golang#215 - `openjdk` minor Debian openjdk bumps - `php` bump to `7.2.4`, `7.1.16`, `7.0.29`, and `5.6.35` - `python` docker-library/python#274 - `tomcat` openssl `1.1.0f-3+deb9u2`
tao12345666333
pushed a commit
to tao12345666333/python
that referenced
this pull request
Jun 28, 2018
3.6/alpine3.7: Build nis module now that 3.6.5 is patched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #266.
Note also there's a Python 3.7.0b3 out now...
guess the bot hasn't got to it yet.