Skip to content

Add tag for Alpine 3.10 #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Add tag for Alpine 3.10 #401

merged 1 commit into from
Jun 24, 2019

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Jun 21, 2019

Closes #398

@tianon tianon merged commit d8d2a41 into docker-library:master Jun 24, 2019
@J0WI J0WI deleted the alpine10-tag branch June 24, 2019 20:16
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 24, 2019
Changes:

- docker-library/python@d8d2a41: Merge pull request docker-library/python#401 from J0WI/alpine10-tag
- docker-library/python@36af208: Add tag for Alpine 3.10
- docker-library/python@e846f9b: Merge pull request docker-library/python#399 from J0WI/alpine10
- docker-library/python@e057559: Add Alpine 3.10 and remove Alpine 3.8
- docker-library/python@1358d77: Update generated README
@ulgens
Copy link

ulgens commented Jun 26, 2019

The issue is closed and PR is merged, but there is no PR about the change to official-images repo yet. How much should we wait? Is it an automated process or someone's responsibility?

Edit: I saw this just after i wrote the comment.

added a commit to docker-library-bot/official-images that referenced this pull request 2 days ago

It seems that PR was created in no time, but i'm not sure it targets the right repo.

@J0WI
Copy link
Contributor Author

J0WI commented Jun 26, 2019

A PR has not yet been created:
docker-library/official-images@master...docker-library-bot:python

@ulgens
Copy link

ulgens commented Jun 26, 2019

@J0WI Thanks. So, how does the process work? Is there a trigger for that or someone creates it manually? Also, why do we have docker-library-bot/official-images@bc698b6 this PR and what does it do?

@J0WI
Copy link
Contributor Author

J0WI commented Jun 26, 2019

I don't know why @docker-library-bot haven't submitted the PR so far. They may want to merge #402 first to avoid rebuilding everything twice.

@ulgens
Copy link

ulgens commented Jun 26, 2019

@J0WI Is it something we can debug?

@tao12345666333
Copy link
Contributor

Please see https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what to understand the process.

@ulgens
Copy link

ulgens commented Jun 26, 2019

@tao12345666333 That's the issue. These steps doesn't work right now. We are stuck at step 2.

@tao12345666333
Copy link
Contributor

@ulgens we can just open a PR for this. docker-library/official-images#6166

@yosifkit
Copy link
Member

The bot only creates us some branches and then @tianon or I will go press the pull request button while double checking that the changes make sense (or if there is another PR that could be included soon to reduce image churn for users). Really anyone could press the "new pull request" button there, since they are all based on changes already committed to the individual repos.

@ulgens
Copy link

ulgens commented Jun 27, 2019

@yosifkit Thanks for the details. I understand the reasoning but "putting updates in Docker Hub" is already a painfuly slow process, and this review - PR process added 3 days to that. Is there any way to make it faster - automated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it planned to release a alpine 3.10 based docker image for python 3.7?
5 participants