Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping Node 0.10, 0.12, and 4 support #1086

Closed
balupton opened this issue Aug 17, 2018 · 5 comments
Closed

Dropping Node 0.10, 0.12, and 4 support #1086

balupton opened this issue Aug 17, 2018 · 5 comments
Labels
2 - developing type discussion only
Milestone
Essential

Comments

@balupton
Copy link
Member

balupton commented Aug 17, 2018 •
edited
Loading

https://github.com/nodejs/Release

Node v4 and below have become increasingly unstable (had several errlop crashes with them) as well as many dependencies have dropped support for them. Node v4 is already unsupported by the node team. Come October, node 6 will also be unsupported by the node team.
@balupton balupton changed the title planning to drop node v4 and below when node v10 goes stable in october planning to drop node v4 and below when node v10 goes active LTS in october Aug 17, 2018
@balupton
Copy link
Member Author

balupton commented Sep 6, 2018

Alright. New dependencies that we will be using only support node 6 and up. Pity they don't use Editions and our Boundation workflow.

@balupton
Copy link
Member Author

balupton commented Sep 6, 2018

So, will be dropping node 4 and below in the next minor release. Which will land sometime in the next 7 days. This will mean min node version for DocPad will be version node version 6.

The next release will revamp the console interactions, and bring all the dependencies up to date.

@RobLoach
Copy link
Contributor

RobLoach commented Sep 6, 2018

Congrats! Since it's a breaking change, should it be a major version release?

@balupton balupton added this to the Essential milestone Sep 6, 2018
@balupton
Copy link
Member Author

balupton commented Sep 6, 2018

Congrats! Since it's a breaking change, should it be a major version release?

Can't do majors until #691 is done, as otherwise a major will break compat with all plugins.

Majors in DocPad break things for everyone. Minors break things for some. As nearly everyone is probably using a modern node version, this fulfils criteria for minor.

balupton added a commit that referenced this issue Sep 6, 2018
@balupton
dropped legacy node version support
25835e5 
close #1086
balupton added a commit that referenced this issue Sep 6, 2018
@balupton
dropped legacy node version support
8afb101 
close #1086
balupton added a commit that referenced this issue Sep 6, 2018
@balupton
dropped legacy node version support
f0c2679 
close #1086
@balupton balupton mentioned this issue Sep 6, 2018
Closed
@balupton balupton changed the title planning to drop node v4 and below when node v10 goes active LTS in october Dropping Node 0.10, 0.12, and 4 support Sep 6, 2018
@RobLoach
Copy link
Contributor

RobLoach commented Sep 6, 2018

Great work Ben! 🎆 🍾

@snyk-bot snyk-bot mentioned this issue Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - developing type discussion only
Projects
None yet
Milestone
Essential
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade docpad from 6.40.0 to 6.82.5 dmitriz/browser-diet
2 participants
@RobLoach @balupton