Skip to content

Missing rel="noreferrer noopener" for links opening in new tab/window #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
vkallore opened this issue Aug 26, 2019 · 3 comments · Fixed by #917
Closed
1 task done

Missing rel="noreferrer noopener" for links opening in new tab/window #914

vkallore opened this issue Aug 26, 2019 · 3 comments · Fixed by #917

Comments

@vkallore
Copy link
Contributor

vkallore commented Aug 26, 2019 •
edited
Loading

Bug Report

Steps to reproduce

Add a link in md file.

What is current behaviour

The default configuration opens a link in new tab/window. Missing rel="noreferrer noopener".

What is the expected behaviour

Don't we need to add rel="noreferrer noopener"?

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: NA

  • Node.js version: NA

  • npm/yarn version: NA

  • Browser version: NA

  • Docsify version: 4.9.4

  • Docsify plugins: NA
@vkallore vkallore mentioned this issue Sep 6, 2019
Merged
19 tasks
@anikethsaha
Copy link
Member

did you try _self in externalLinkTarget ?

@vkallore
Copy link
Contributor Author

vkallore commented Dec 2, 2019

Sorry missed this comment as we continued discussion on the PR #917

@anikethsaha
Copy link
Member

Issue description is explained in details in #917

anikethsaha added a commit that referenced this issue Dec 2, 2019
@anikethsaha
Merge pull request #917 from vkallore/develop
378d7bb 
Fix #914
@denydias denydias mentioned this issue May 18, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #914 vkallore/docsify-1
2 participants
@vkallore @anikethsaha