add external-script plugin #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QingWei-Li
reviewed
Mar 7, 2017
src/plugins/external-script.js
Outdated
| if (asyncReg.test(scriptMatch[0])) script.setAttribute('async', '') | ||
| if (deferReg.test(scriptMatch[0])) script.setAttribute('defer', '') | ||
|
|
||
| const target = document.querySelector('#main') |
There was a problem hiding this comment.
大佬不如缓存下 dom 吧，省点是点，或者你可以用 Docsify.dom.getNode，还有补充下文档说明下可以用 jsfiddle 了吧
大佬辛苦了
|
好了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
大佬请过目