Skip to content

fix some minor issues #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2017
Merged

fix some minor issues #132

merged 3 commits into from
Mar 15, 2017

Conversation

jrappen
Copy link
Contributor

@jrappen jrappen commented Mar 15, 2017

See commits for details.

I did not:

  • rebuild
  • bump the version
  • update the yarn.lock file as I'm not using yarn

jrappen added 3 commits March 15, 2017 22:07
* remove "themes" from "files" as it is a subfolder of "src"
* reorder elements
* update dependencies
* update devDependencies
* make author a dictionary
@QingWei-Li QingWei-Li merged commit 65a6b3c into docsifyjs:master Mar 15, 2017
@jrappen
Copy link
Contributor Author

jrappen commented Mar 15, 2017

@QingWei-Li I was just looking at https://github.com/QingWei-Li/docsify/blob/master/.gitignore and upon inspection I thought 54da5fb might contain an error, where "themes" shouldn't have been removed from "files"? If I made a mistake I'm sorry, I'm not fluent in JavaScript.

@QingWei-Li
Copy link
Member

Yes, we need to keep "themes"

@jrappen
Copy link
Contributor Author

jrappen commented Mar 15, 2017

see #133

QingWei-Li added a commit that referenced this pull request Mar 15, 2017
fix erroneously removal of "themes" from files, fix #132
kazuma512 added a commit to kazuma512/docsify that referenced this pull request Jun 6, 2023
lucascampos777 added a commit to lucascampos777/Digital-marketing-agency that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants