fix: exception when using hideSidebar #1393
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/a8rjk2am2 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d2de52f:
|
There was a problem hiding this comment.
I think this will result in inconsistent styling if suppose the first line runs successfully but there is an error in second-line then aside..sidebar will be removed already but not the rest of the styling as it would return null. (let me know if I am missing anything)
How about checking all these in one if statement
like this
if( document.querySelector('aside.sidebar') && document.querySelector('button.sidebar-toggle') && ...){
document.querySelector('aside.sidebar').remove();
document.querySelector('button.sidebar-toggle').remove();
...
}What do you think ?
|
I think it's good, we just need to judge |
|
Cool, You can make changes in this PR itself |
Summary
fix #1392
If there is a better solution, you can also submit other PR.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.