Properly handle anchor links local within a file. Fix #142 #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he generated path. fixes #142
QingWei-Li
reviewed
Mar 30, 2017
src/core/route/hash.js
Outdated
| @@ -66,11 +66,14 @@ export function parse (path = window.location.href) { | |||
| * @param {object} qs query params | |||
| */ | |||
| export function toURL (path, params) { | |||
| const inline = path[0] === '#'; | |||
|
fixed. sorry, i actually don't use semi's myself, but got used to looking at the built version which had semis, and didn't realize the actual code here omits them. |
|
I'll have to properly redo this. I didn't realize the code is a bit different than the built / bundled app. |
…ose local anchor links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in toURL test for anchor links and if so prepend the currentPath to t…he generated path. fixes #142.
Please makes sure these boxes are checked before submitting your PR, thank you!
masterbranch.