Skip to content

Describe ordering requirement for prism script tag #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

ablakey
Copy link
Contributor

@ablakey ablakey commented Dec 10, 2022

Summary

I couldn't get a prism typescript language grammar to work until I realised that script order mattered.

This might not be the best language or format for this, but I think it probably belongs in the documentation in some manner.

What kind of change does this PR introduce?

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

I couldn't get a prism typescript language grammar to work until I realised that script order mattered.   

This might not be the best language or format for this, but I think it probably belongs in the documentation in some manner.

Thank you!
@vercel
Copy link

vercel bot commented Dec 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docsify-preview ✅ Ready (Inspect) Visit Preview Dec 10, 2022 at 3:31PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 342d93c:

Sandbox Source
docsify-template Configuration

@sy-records sy-records requested a review from a team December 11, 2022 00:27
@Koooooo-7 Koooooo-7 merged commit f4cae7f into docsifyjs:develop Dec 12, 2022
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants