Skip to content

chore: docsify-ignore config polish. #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2023
Merged

chore: docsify-ignore config polish. #1994

merged 3 commits into from
Feb 23, 2023

Conversation

Koooooo-7
Copy link
Member

Summary

Update the option 2 to use docsify-ignore.

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Feb 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 6:36AM (UTC)

@Koooooo-7 Koooooo-7 requested a review from a team February 21, 2023 03:13
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 21, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7bd9ef5:

Sandbox Source
docsify-template Configuration

sy-records
sy-records reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to be modified.

Why do you want to modify here?

@Koooooo-7
Copy link
Member Author

Koooooo-7 commented Feb 21, 2023 •
edited
Loading

I don't think it needs to be modified.

Why do you want to modify here?

We have two ways to config the ignore setting.
both <!-- {docsify-ignore-all} --> and {docsify-ignore-all} works. we should mention them all here. and the {docsify-ignore-all} is useful when u do not wanna meet someone html escape issue.

I gonna refine the doc.

@sy-records
Copy link
Member

That should add a more detailed description, now this change can be easily misinterpreted as a contextual error.

@Koooooo-7 Koooooo-7 requested a review from sy-records February 21, 2023 05:26
@Koooooo-7
Copy link
Member Author

That should add a more detailed description, now this change can be easily misinterpreted as a contextual error.

yep, I update it.

@Koooooo-7 Koooooo-7 merged commit 898e6ee into develop Feb 23, 2023
@Koooooo-7 Koooooo-7 deleted the ignore-chore branch February 23, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sy-records sy-records sy-records approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Koooooo-7 @sy-records