Skip to content

Added capability to add css class and id to images + links + refactoring #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 8, 2020
Merged

Added capability to add css class and id to images + links + refactoring #820

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa780d0
dont commit lib files
arelstone Apr 15, 2019
eb10263
Update package.json
arelstone Apr 23, 2019
1a312a6
Merge branch 'develop' into develop
arelstone May 18, 2019
e8abb5d
fix conflictes with upstream/develop
arelstone Feb 7, 2020
073afdd
added tests for refactored render-methods
arelstone Feb 7, 2020
bea0ce5
pr comments
arelstone Feb 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
pr comments
  • Loading branch information
@arelstone
arelstone committed Feb 8, 2020
commit bea0ce5fdb66ee0e390401d3bf84c35f90f4d94e
1 change: 0 additions & 1 deletion cypress/integration/sidebar/config.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ context('sidebar.configurations', () => {
'set-target-attribute-for-link',
'disable-link',
'github-task-lists',
'image-resizing',
'customise-id-for-headings',
'markdown-in-html-tag'
]
Expand Down
Binary file removed ...nfig.spec.js/sidebar.configurations -- go to #helpersid=image-resizing.snap.png
View file
Open in desktop
Binary file not shown.
5 changes: 2 additions & 3 deletions src/core/render/compiler/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ export const imageCompiler = ({ renderer, contentBase, router }) => renderer.ima
attrs.push(`title="${title}"`)
}

const size = config.size
if (size) {
const [width, height] = size.split('x')
if (config.size) {
const [width, height] = config.size.split('x')
if (height) {
attrs.push(`width="${width}" height="${height}"`)
} else {
Expand Down