-
Notifications
You must be signed in to change notification settings - Fork 33
Add PublicKey to "InternalsVisibleTo" assemblies in MonoDevelop.TextE… #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR builds without error on linuxmint, which is based on ubuntu, so I'm not sure why the CI / linux run fails, though the error log shows that the PublicKey used is not being valid. I've now updated this to use the PublicKey from main/external/mono-addins/mono-addins.snk, which I'm hoping will be a valid choice. The ubuntu 20.04 software environment that CI uses contains mono-6.12.0 and msbuild-16.6.0, which won't actually prove the PR, but if it passes CI, it should be OK when building with msbuild 16.9.0 and 16.10.1. I'm not sure of the easiest way to add this latest commit to the PR - some help would be appreciated! |
Adding another commit to the PR was the easy bit! The CI run fails, but not with any error related to the PR changes. In fact, a CI run on my own fork fails on the |
seems that some fsharp-stuff is not installed in the CI |
I'll try and add all the mono, msbuild fsharp, gtk-sharp stuff explicitly to the CI environment (just as for the VM) and see if it makes any difference. fsharp ought to be there, but we'll see. |
Well, that was interesting. CI run passes OK on the |
can't see what's the difference. anyway, it's building now, so someone can optimize it again
yes, i thing its better to have extra PR for CI-change |
e6c0056
to
0473a39
Compare
…l/mono-addins/mono-addins.snk Add PublicKey to assemblies referenced with "InternalsVisibleTo" in MonoDevelop.TextEditor.csproj This now seems to be checked by msbuild versions > 16.8.0
0473a39
to
2050cc6
Compare
maybe kick out MonoDevelop.TextEditor.Cocoa & MonoDevelop.TextEditor.Wpf - we don't need them |
I'd prefer to just merge as-is, which lets dotdevelop build with msbuild versions 16.9.0 and 16.10.1 Pruning the (redundant?) Windows and Mac code can be left until dotdevelop is working on .NET 5.0 (!) |
All changes in openssl_test reverted. Now uptodate with main Add PublicKey to "InternalsVisibleTo" assemblies in MonoDevelop.TextE…
…ditor.csproj
It seems that msbuild 16.9.0 and 16.10.1 (the latest releases) enforce the requirement to specify a public key for assemblies to which "InternalsVisibleTo" declarations are made. This now needs to be done by MonoDevelop.TextEditor for assemblies MonoDevelop.TextEditor.Wpf and MonoDevelop.TextEditor.Cocoa. This commit fixes the build for msbuild versions 16.9.0 and 16.10.1