Skip to content

Update sample readme for Create gRPC client & server #18169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

Update sample readme for Create gRPC client & server #18169

merged 1 commit into from
May 7, 2020

Conversation

wadepickett
Copy link
Contributor

@wadepickett wadepickett commented May 7, 2020 •
edited
Loading

For Internal Review: I am not sure how to get a review build for sample readme.md files which lacks structure used by the review build process.

Fixes #16467

Updated the readme.md to point to the sample tutorial rather than duplicate the tutorial in the readme itself which became quickly out of date.

@wadepickett wadepickett self-assigned this May 7, 2020
@wadepickett
Copy link
Contributor Author

wadepickett commented May 7, 2020 •
edited
Loading

@Rick-Anderson, I'm not sure how to get a review build and URI for this sample readme.md.
I don't think I can. So the review would have to be of just the changed readme.md itself.

@wadepickett wadepickett marked this pull request as ready for review May 7, 2020 02:48
@wadepickett wadepickett requested a review from Rick-Anderson May 7, 2020 02:48
@Rick-Anderson
Copy link
Contributor

You can add the readme content to one of your repos like I did here

I don't see any value to the readme, I think you can delete it. All the info is in a tutorial, right?

@wadepickett
Copy link
Contributor Author

The only value the readme provides, is a way for the sample to be discoverable through the sample browser system. The readme is required by the sample system for that to happen.

Rick-Anderson
Rick-Anderson approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, assuming we want to keep this.

@wadepickett
Copy link
Contributor Author

For now, I will update the readme so it at least points to the right tutorial until I can get it removed from the samples system.

@wadepickett wadepickett merged commit 96de453 into master May 7, 2020
@wadepickett wadepickett deleted the wade-pickett/gprc-sample-readme-5-6 branch May 7, 2020 03:27
@wadepickett
Copy link
Contributor Author

@Rick-Anderson, sorry, I forgot I didn't have patches to squash and squashed when merging. I will try to remember not to do that.

@wadepickett
Copy link
Contributor Author

Fixes #16467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rick-Anderson Rick-Anderson Rick-Anderson approved these changes

Assignees

@wadepickett wadepickett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retire duplicate Create a gRPC client and server in ASP.NET Core 3.0 using Visual Studio
2 participants
@wadepickett @Rick-Anderson