Make nbgv install
observe the default branch name when creating version.json
#1243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nbgv install
command was hardcoding "master" as the first public release branch in the generatedversion.json
file, regardless of the actual default branch name in the repository. This caused issues in repositories using "main", "develop", or other branch names as their default.Changes Made
This PR implements automatic default branch detection that works with all GitContext types:
LibGit2Context Implementation
For repositories using LibGit2Sharp (ReadWrite engine), the implementation:
upstream
>origin
> any other remoteinit.defaultBranch
if the branch exists locallymaster
,main
,develop
in that orderAlternative Implementation for Other Contexts
For ManagedGitContext (ReadOnly engine) and other context types, the implementation reads
.git
directory files directly:refs/remotes/{remote}/HEAD
files for remote HEAD referencesrefs/remotes/
directory to find available remotesrefs/heads/
directory andpacked-refs
file for local branches.git/config
and global config forinit.defaultBranch
settingBoth implementations follow the same priority algorithm to ensure consistent behavior across all git engines.
Example Behavior
Before:
After (in a main-based repo):
Testing
Fixes #717.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.