Fix inconsistent CLI output format for GitCommitDate #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Copilot finished work on behalf of
AArnott
August 10, 2025 19:28
AArnott
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI output format for
GitCommitDatewas inconsistent between different output methods, making it difficult to parse dates reliably in scripts and automation.Problem:
nbgv get-version -v GitCommitDateoutputs locale-specific format:08/10/2025 19:10:07 +00:00nbgv get-version -f jsonoutputs ISO 8601 format:"GitCommitDate": "2025-08-10T19:10:07+00:00"This inconsistency made it challenging to write portable automation scripts that needed to parse commit dates, as the format would vary depending on the system locale and output method used.
Solution:
Modified the individual variable output logic in
Program.csto formatDateTimeOffsetproperties using the ISO 8601 standard ("o" format specifier) to match the JSON output behavior. This ensures all CLI output methods use a consistent, machine-readable date format.After the fix:
nbgv get-version -v GitCommitDate:2025-08-10T19:10:07.0000000+00:00(ISO 8601)nbgv get-version -f json:"GitCommitDate": "2025-08-10T19:10:07+00:00"(ISO 8601)The change also applies to
GitCommitAuthorDateand any otherDateTimeOffsetproperties, while maintaining full compatibility with all other property types.Fixes #485.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.mscurl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED(dns block)dotnetbuilds.azureedge.netcurl --retry 20 --retry-delay 2 --connect-timeout 15 -sSL -f --create-dirs REDACTED(dns block)curl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.