Fix VSync not being respected on window creation #2005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the cause may be the change in video mode i.e. when it goes full screen, the swap interval is reset. My impression was that we had logic somewhere in there already to set SwapInterval after creation (or at least I have a feeling that I wrote that at some point in the last 5 years, possibly in DoRender where we try to detect if we’ve done it already maybe) |
|
Yes, in ViewImplementationBase.cs: public bool VSync
{
get => _optionsCache.VSync;
set
{
_swapIntervalChanged = true;
_optionsCache.VSync = value;
}
} public void DoRender()
{
[...]
if ((delta >= _renderPeriod) || VSync)
{
[...]
if (!IsContextControlDisabled && _swapIntervalChanged)
{
GLContext?.SwapInterval(VSync ? 1 : 0);
_swapIntervalChanged = false;
}
[...]
}
[...]
}I was going to suggest we initialize // Ensure we keep SwapInterval up-to-date
private bool _swapIntervalChanged = true;Not sure what's going on here |
|
Setting _swapIntervalChanged to true probably makes sense in CoreInitialize. I think we should also set that to true whenever we change the window state or monitor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Fixes #2000.
I'm having issues compiling ATM so I couldn't test this yet, and I'm out of time to work on this for today. I'll get back to this soon enough