Improve renderer unit test #62016
Merged
Improve renderer unit test #62016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
reviewed
May 20, 2025
javiercn
approved these changes
May 20, 2025
Co-authored-by: Javier Calvarro Nelson <jacalvar@microsoft.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies feedback from #61633. We wanted to merge the original PR asap, without re-running the CI.
Description
DoesNotRenderChildAfterRendererStopped-> it was testing if illegal render was possible after we stopped the renderer, the feedback suggested a flow of: render 1st time -> stop renderer - render 2nd time and check if render batches number grew.TestEndpointHtmlRendererhad its own mechanism of stopping the renderer, not connected to base's class stopping. Making theEndpointHtmlRendererstopping method internal, allows the test to call it. Because we wantTestEndpointHtmlRendererto keep track of the number of batches rendered, we keep the stopping method onTestEndpointHtmlRendereras well.FeatureSwitchDefinitionshould reuse once defined string.