Fix logic for .msi version in Hosting Bundle #62147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
May 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how the MSI version is computed for the hosting bundle by introducing a dedicated NonStableVersion property and updating the installer path normalization to use it.
- Introduce
NonStableVersionMSBuild property with conditional logic to append prerelease/build labels. - Update
CrossArchitectureInstallerBasePathNormalizedto referenceNonStableVersioninstead ofSharedFxMsiVersion.
Comments suppressed due to low confidence (2)
src/Installers/Windows/WindowsHostingBundle/WindowsHostingBundle.wixproj:107
- The condition checks for the absence of
$(_BuildNumberLabels)instead of$(_PreReleaseLabel). If the intention is to append labels only when there is no prerelease label, the condition should verify! $(NonStableVersion.Contains('$(_PreReleaseLabel)'))instead.
<NonStableVersion Condition="! $(NonStableVersion.Contains('$(_BuildNumberLabels)'))">$(PackageVersion)-$(_PreReleaseLabel)$(_BuildNumberLabels)</NonStableVersion>
src/Installers/Windows/WindowsHostingBundle/WindowsHostingBundle.wixproj:105
- [nitpick] Consider adding an MSBuild integration test or target that verifies
NonStableVersionyields the correct values for both stable and prerelease scenarios to prevent regressions.
<NonStableVersion>$(PackageVersion)</NonStableVersion>
src/Installers/Windows/WindowsHostingBundle/WindowsHostingBundle.wixproj
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aspnetcore-runtime .msi will have a stable version in servicing, but we always need to calculate the non-stable version for when we restore assets in VMR build pass 2. Fixes #61951