Fix bounds check in test code #62180
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an erroneous bounds check that allowed the element after the last to be pinned.
|
Thanks for your PR, @@Emik03. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bounds check in test code
A single bounds check from a class used in test code (
DiagonsticPoolBlock.cs) has been corrected.Description
I was implementing
MemoryManager<T>in my own project but needed to find an example implementation of thePinmethod to ensure I did everything correctly. Looking through grep.app, I found the file this pull request is about and took note of what it did, but then looking closer I saw a bounds check that looked wrong.Sure enough, this class does allow you to pin the element that comes after the last. (i.e.
block.Pin(memoryOwner.Memory.Length)). I'm aware that this code is only used for testing, so as far as bugs are concerned this is very low priority, but it's better to fix it before it causes problems given that the type is in a shared project, implying that this type may be reused and could cause a future problem.I hope you don't mind me sending a PR without a corresponding issue, as I believe opening an issue for something this small would only slow both me and the maintainers down. The bounds check that I replaced it with is based on what I've seen the most from the runtime repository to maintain some consistency.