[OpenAPI] Refactor MapOpenApi #62194
Merged
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the `MapOpenApi()` method to avoid two almost identical code blocks.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MapOpenApi method to reduce duplicate code by assigning the differing values into variables.
- Removed duplicate calls to context.Response.StartAsync() and SerializeAsync for YAML and JSON paths
- Introduced variables for content type and the OpenApiWriter instance for streamlined logic
captainsafia
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor MapOpenApi
Refactor the
MapOpenApi()method.Description
Refactor the
MapOpenApi()method to avoid two almost identical code blocks by assigning the differing values into variables and then using.Subjective change, so feel free to close if you preferred it as it was.