-
Notifications
You must be signed in to change notification settings - Fork 10.4k
feat(HTTP.SYS): on-demand TLS client hello retrieval #62209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(HTTP.SYS): on-demand TLS client hello retrieval #62209
Conversation
public interface IHttpSysRequestPropertyFeature | ||
{ | ||
/// <summary> | ||
/// Reads the TLS client hello from HTTP.SYS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdykstra for docs pass?
src/Servers/HttpSys/samples/TlsFeaturesObserve/TlsFeaturesObserve.csproj
Show resolved
Hide resolved
src/Servers/HttpSys/src/RequestProcessing/RequestContext.FeatureCollection.cs
Show resolved
Hide resolved
return true; | ||
} | ||
} | ||
bytesReturned = (int)bytesReturnedValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bytesReturned = (int)bytesReturnedValue; | |
bytesReturned = checked((int)bytesReturnedValue); |
} | ||
}, LoggerFactory)) | ||
{ | ||
// nothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to send a request for the test to actually do anything
@@ -188,7 +188,7 @@ public static ListenOptions UseHttps(this ListenOptions listenOptions, Action<Ht | |||
/// <see cref="KestrelServerOptions.ConfigureHttpsDefaults(Action{HttpsConnectionAdapterOptions})"/>. | |||
/// </summary> | |||
/// <param name="listenOptions">The <see cref="ListenOptions"/> to configure.</param> | |||
/// <param name="httpsOptions">Options to configure HTTPS.</param> | |||
/// <param name="httpsOptions">Options to configure HTTPS.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// <param name="httpsOptions">Options to configure HTTPS.</param> | |
/// <param name="httpsOptions">Options to configure HTTPS.</param> |
HTTP.SYS only on-demand TLS client hello
As discussed in api proposal we are doing 2 things here:
HttpSysOptions.TlsClientHelloBytesCallback
IHttpSysRequestPropertiesFeature
:IHttpSysRequestPropertiesFeature.TryGetTlsClientHello
.TlsFeaturesObserve.Program
sample shows the usage of that feature and this API in particular:Implements #61625