Improve antiforgery error message for unauthenticated users with authenticated tokens #63241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error message for a common antiforgery validation scenario where developers mistakenly place
.UseAntiforgery()
before.UseAuthentication()
in their middleware pipeline.Problem
The current error message
"The provided antiforgery token was meant for a different claims-based user than the current user"
is not helpful when the real issue is middleware ordering. This occurs when:Solution
Added logic to detect this specific scenario and provide a more actionable error message:
The detection works by checking if:
GetAuthenticatedIdentity(httpContext.User) == null
)requestToken.ClaimUid != null
OR!string.IsNullOrEmpty(requestToken.Username)
)Changes Made
AntiforgeryToken_ClaimUidMismatch_UnauthenticatedUser
with the improved messageDefaultAntiforgeryTokenGenerator.TryValidateTokenSet()
to detect the unauthenticated user scenario in both username mismatch and ClaimUid mismatch validation pathsTesting
This change makes it much easier for developers to diagnose and fix the common middleware ordering issue.
Fixes #63218.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.