Skip to content

Add QUERY to known HTTP methods in HostingMetrics #63276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add QUERY to known HTTP methods in HostingMetrics #63276

wants to merge 1 commit into from
+1 −0

Conversation

doominator42
Copy link

As discussed in #61089 (comment), this PR is for adding QUERY to the known HTTP methods for hosting metrics.

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

@doominator42 doominator42 requested a review from halter73 as a code owner August 15, 2025 14:09
@github-actions github-actions bot added the area-hosting Includes Hosting label Aug 15, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 15, 2025
martincostello
martincostello reviewed Aug 15, 2025
View reviewed changes
src/Hosting/Hosting/src/Internal/HostingMetrics.cs Outdated
@@ -127,6 +127,7 @@ private static object GetBoxedStatusCode(int statusCode)
KeyValuePair.Create(HttpMethods.Patch, HttpMethods.Patch),
KeyValuePair.Create(HttpMethods.Post, HttpMethods.Post),
KeyValuePair.Create(HttpMethods.Put, HttpMethods.Put),
KeyValuePair.Create(HttpMethods.Query, HttpMethods.Query),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#62090 (review)

@build-analysis build-analysis bot mentioned this pull request Aug 15, 2025
Open
@captainsafia
Copy link
Member

It looks like based on the linked discussion we need to put this in a holding pattern until the discussion in #62090 (review) is resolved.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Aug 27, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Aug 27, 2025
@doominator42
Copy link
Author

#62090 is now merged, I rebased my branch on top of it.

For the OTEL semantics, according to open-telemetry/semantic-conventions#2642 (comment), adding methods known to the instrumentation is ok and since QUERY is now supported it would still follow conventions.

Also, I did not find any tests specific to the known HTTP methods, should I just add new ones or this is good to go?

@doominator42 doominator42 reopened this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia

1 more reviewer

@martincostello martincostello martincostello left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-hosting Includes Hosting community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
11.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@doominator42 @captainsafia @martincostello