More parsing improvements#2016

Merged

adamsitnik merged 12 commits intodotnet:mainfrom

adamsitnik:moreParsingImprovements

Jan 12, 2023

Commits on Jan 11, 2023

remove Parent property from SyntaxNode as it's used only in one place
adamsitnik
committed
make NonterminalSyntaxNode.Children nullable to reduce number of JIT compilations
adamsitnik
committed
don't store a dedicated list of OptionResults, re-use data present in symbolResults dictionary
adamsitnik
committed

Commits on Jan 12, 2023

avoid unnecessary casting:
adamsitnik
committed
We own Symbol->SymbolResult dictionary and we know that for each Argument key the value can be only ArgumentResult etc
adamsitnik
committed
seal ArgumentResult, OptionResult and RootCommandResult
adamsitnik
committed
remove unused internal type (SymbolResultVisitor)
adamsitnik
committed
remove Root property, we already have Parent property and can get the Root very quickly
adamsitnik
committed
don't use SymbolResult.Symbol property when more specific information is available
adamsitnik
committed
seal more internal derived types
adamsitnik
committed
only CommandResult can have Children of OptionResult type
adamsitnik
committed
don't allocate an array if all we care about is the last element
adamsitnik
committed