More SymbolResult improvements #2027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal) and make all virtual SymbolResult methods non-virtual and delegating to SymbolResultTree
…esultTree as internal field, optimize SymbolResultTree.GetChildren for AgumentResult
* it makes SymbolResultTree more responsible and less artificial (subjective) * it removes one allocation (nit)
…ages don't need to modify it
|
The CI has still not started, will close and reopen the PR. |
jonsequitur
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to finish the removal of a list copy per symbol result:
d84ca2a
b28a616
I've run into situation where I am not sure whether this will be possible to implement, I'll finish that tomorrow.