Rename Option.IsGlobal to AppliesToSelfAndChildren, make it public #2060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
approved these changes
Feb 17, 2023
| @@ -495,7 +495,11 @@ public async Task A_custom_validator_added_to_a_global_option_is_checked(string | |||
| { | |||
| var handlerWasCalled = false; | |||
|
|
|||
| var globalOption = new Option<int>("--value"); | |||
| var globalOption = new Option<int>("--value") | |||
There was a problem hiding this comment.
Do we want to rename this local since we are removing the global concept?
There was a problem hiding this comment.
I was thinking about it, but I was unable to come up with a better name. appliesToSelfAndChildrenOption? inheritableOption?
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2055
Note from #2055: "This might be not the final name, we might rename it once the API gets approved by .NET Team API Review Board (.NET 8 Preview 3-4 timeframe)"