Skip to content

System.Reflection.Emit.AssemblyBuilder: Fix the AssemblyBuilder example not to ignore created instances #10238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

System.Reflection.Emit.AssemblyBuilder: Fix the AssemblyBuilder example not to ignore created instances #10238

merged 1 commit into from
Aug 12, 2024

Conversation

kiripon
Copy link
Contributor

@kiripon kiripon commented Aug 12, 2024 •
edited
Loading

Summary

Fix the System.Reflection.Emit.AssemblyBuilder example not to ignore the instance.
Before this change, the expression pi?.GetValue(o2, null) failed with error because o2 is always null.

@kiripon kiripon requested a review from a team as a code owner August 12, 2024 07:59
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 12, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit f7d84ce:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Reflection.Emit/AssemblyBuilder/Overview/24895.cs ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kiripon

I'll :shipit: now.

@BillWagner BillWagner merged commit e11219f into dotnet:main Aug 12, 2024
3 checks passed
@kiripon kiripon deleted the fix-assembly-builder-example branch August 13, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
area-System.Reflection.Emit community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiripon @BillWagner @quadmist