Remove incorrect "unique" claim from DateTimeFormatInfo.ShortestDayNames documentation #11754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tarekgh <10833894+tarekgh@users.noreply.github.com>
Co-authored-by: tarekgh <10833894+tarekgh@users.noreply.github.com>
Copilot finished work on behalf of
tarekgh
September 1, 2025 18:34
|
@copilot revert the change in the sample code. |
Co-authored-by: tarekgh <10833894+tarekgh@users.noreply.github.com>
Copilot finished work on behalf of
tarekgh
September 1, 2025 20:01
tarekgh
approved these changes
Sep 1, 2025
|
@adegeo could you please help review this simple change and merge if possible? Thansk! |
gewarren
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DateTimeFormatInfo.ShortestDayNamesproperty documentation incorrectly claimed it returns "unique" abbreviated day names, but according to the Unicode CLDR specification, shortest day names are defined as single characters which might not be unique.Changes Made
Documentation Fix:
DateTimeFormatInfo.xmlWhy This Fix Is Necessary
The documentation should not promise "unique" because:
As noted by @tarekgh in the issue, this aligns with removing the word "unique" from the documentation to accurately reflect the specification rather than current implementation details.
Fixes #11752.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.