[RTM] Automatic port of System.Net.Http.SocketsHttpHandler #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
commented
Oct 9, 2020
carlossanlop
commented
Oct 9, 2020
carlossanlop
commented
Oct 9, 2020
carlossanlop
commented
Oct 9, 2020
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Oct 9, 2020
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Oct 9, 2020
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
safern
reviewed
Oct 9, 2020
| <summary>To be added.</summary> | ||
| <value>To be added.</value> | ||
| <summary>The initial HttpRequestMessage that is causing the connection to be created.</summary> | ||
| <value>An HttpRequestMessage instance causing the connection to be created.</value> | ||
| <remarks>To be added.</remarks> |
There was a problem hiding this comment.
There were no remarks in triple slash to port, and the default string for empty remarks is To be added.
aik-jahoda
reviewed
Oct 9, 2020
gewarren
approved these changes
Oct 9, 2020
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
|
Docs Build status updates of commit e0a4193: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Thanks @carlossanlop -- looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the last APIs for 5.0, introduced in RC2: dotnet/runtime#42563
@geoffkizer @aik-jahoda @scalablecory @gewarren @safern