Skip to content

.NET Framework -> .NET #5032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2020
Merged

.NET Framework -> .NET #5032

merged 2 commits into from
Oct 30, 2020

Conversation

gewarren
Copy link
Contributor

Contributes to dotnet/docs#20543.
Updates API summaries only (mostly).

@gewarren gewarren requested a review from carlossanlop October 24, 2020 00:32
@opbld34
Copy link

opbld34 commented Oct 24, 2020

Docs Build status updates of commit 7a3c0fa:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Security.Permissions/SecurityPermissionFlag.xml ⚠️Warning View Details
xml/System.Globalization/CultureAndRegionModifiers.xml ✅Succeeded View
xml/System.Globalization/RegionInfo.xml ✅Succeeded View
xml/System.Reflection/AssemblyContentType.xml ✅Succeeded View
xml/System.Resources/ResXResourceWriter.xml ✅Succeeded View
xml/System.Resources/ResourceWriter.xml ✅Succeeded View
xml/System.Runtime.Caching.Configuration/CachingSectionGroup.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/CallConvFastcall.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/HasCopySemanticsAttribute.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/RuntimeHelpers.xml ✅Succeeded View
xml/System.Runtime.InteropServices/ComEventsHelper.xml ✅Succeeded View
xml/System.Runtime.Serialization/XsdDataContractExporter.xml ✅Succeeded View
xml/System.Runtime.Versioning/FrameworkName.xml ✅Succeeded View
xml/System.Runtime.Versioning/TargetFrameworkAttribute.xml ✅Succeeded View
xml/System.Runtime/AssemblyTargetedPatchBandAttribute.xml ✅Succeeded View
xml/System.Runtime/TargetedPatchingOptOutAttribute.xml ✅Succeeded View
xml/System.Security.Claims/ClaimsIdentity.xml ✅Succeeded View
xml/System.Windows.Documents.Serialization/SerializerDescriptor.xml ✅Succeeded View
xml/System.Windows.Forms/LinkLabel.xml ✅Succeeded View
xml/System.Windows.Interop/IErrorPage.xml ✅Succeeded View
xml/System.Windows.Markup/ArrayExtension.xml ✅Succeeded View
xml/System.Windows.Markup/MarkupExtension.xml ✅Succeeded View
xml/System.Windows/AttachedPropertyBrowsableAttribute.xml ✅Succeeded View
xml/System.Windows/AttachedPropertyBrowsableWhenAttributePresentAttribute.xml ✅Succeeded View
xml/System.Windows/MessageBoxOptions.xml ✅Succeeded View
xml/System/UriIdnScope.xml ✅Succeeded View

xml/System.Security.Permissions/SecurityPermissionFlag.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-5.0 can't match any assembly.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

carlossanlop
carlossanlop reviewed Oct 26, 2020
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and a question.

xml/System.Runtime.CompilerServices/HasCopySemanticsAttribute.xml Outdated
@@ -42,7 +42,7 @@
</Attribute>
</Attributes>
<Docs>
<summary>This class is not used in the .NET Framework version 2.0 and is reserved for future use. This class cannot be inherited.</summary>
<summary>This class is reserved for future use. This class cannot be inherited.</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this summary is obsolete now, and we are already using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgani-msft Is this description for HasCopySemanticsAttribute still accurate?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren this attribute is obsolete and neither referenced nor emitted by the C++/CLI compiler.

gewarren
gewarren commented Oct 26, 2020
View reviewed changes
@gewarren @carlossanlop
Apply suggestions from code review
a3db595 
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
@opbld31
Copy link

opbld31 commented Oct 26, 2020

Docs Build status updates of commit a3db595:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Security.Permissions/SecurityPermissionFlag.xml ⚠️Warning View Details
xml/System.Globalization/CultureAndRegionModifiers.xml ✅Succeeded View
xml/System.Globalization/RegionInfo.xml ✅Succeeded View
xml/System.Reflection/AssemblyContentType.xml ✅Succeeded View
xml/System.Resources/ResXResourceWriter.xml ✅Succeeded View
xml/System.Resources/ResourceWriter.xml ✅Succeeded View
xml/System.Runtime.Caching.Configuration/CachingSectionGroup.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/CallConvFastcall.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/HasCopySemanticsAttribute.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/RuntimeHelpers.xml ✅Succeeded View
xml/System.Runtime.InteropServices/ComEventsHelper.xml ✅Succeeded View
xml/System.Runtime.Serialization/XsdDataContractExporter.xml ✅Succeeded View
xml/System.Runtime.Versioning/FrameworkName.xml ✅Succeeded View
xml/System.Runtime.Versioning/TargetFrameworkAttribute.xml ✅Succeeded View
xml/System.Runtime/AssemblyTargetedPatchBandAttribute.xml ✅Succeeded View
xml/System.Runtime/TargetedPatchingOptOutAttribute.xml ✅Succeeded View
xml/System.Security.Claims/ClaimsIdentity.xml ✅Succeeded View
xml/System.Windows.Documents.Serialization/SerializerDescriptor.xml ✅Succeeded View
xml/System.Windows.Forms/LinkLabel.xml ✅Succeeded View
xml/System.Windows.Interop/IErrorPage.xml ✅Succeeded View
xml/System.Windows.Markup/ArrayExtension.xml ✅Succeeded View
xml/System.Windows.Markup/MarkupExtension.xml ✅Succeeded View
xml/System.Windows/AttachedPropertyBrowsableAttribute.xml ✅Succeeded View
xml/System.Windows/AttachedPropertyBrowsableWhenAttributePresentAttribute.xml ✅Succeeded View
xml/System.Windows/MessageBoxOptions.xml ✅Succeeded View
xml/System/UriIdnScope.xml ✅Succeeded View

xml/System.Security.Permissions/SecurityPermissionFlag.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-5.0 can't match any assembly.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor Author

@carlossanlop Can you take another look and approve if you agree?

carlossanlop
carlossanlop approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the change, @gewarren.

@carlossanlop
Copy link
Contributor

@joelmartinez @TianqiZhang the CI threw these warnings. Known issue?:

Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.1 can't match any assembly.
Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.2 can't match any assembly.
Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.0 can't match any assembly.
Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.1 can't match any assembly.
Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-5.0 can't match any assembly.

@gewarren gewarren merged commit 5202cd1 into dotnet:master Oct 30, 2020
@gewarren gewarren deleted the the-rest-nf branch October 30, 2020 17:46
@eiriktsarpalis eiriktsarpalis added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgani-msft tgani-msft tgani-msft left review comments

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees
No one assigned
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gewarren @opbld34 @opbld31 @carlossanlop @tgani-msft @eiriktsarpalis