Skip to content

CNG classes don't work on non-windows platforms #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

luizhlelis
Copy link
Contributor

Summary

CNG classes doc update. A note was added explaining that they don't work on non-Windows platforms.

Fixes #3503

@ghost ghost added the area-System.Security Issues related to security practices for .NET developers. label Oct 26, 2021
@ghost
Copy link

ghost commented Oct 26, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

CNG classes doc update. A note was added explaining that they don't work on non-Windows platforms.

Fixes #3503

Author: luizhlelis
Assignees: -
Labels:

area-System.Security

Milestone: -

@opbld33
Copy link

opbld33 commented Oct 26, 2021

Docs Build status updates of commit b8e4880:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Security.Cryptography/CngKey.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Oct 26, 2021

Docs Build status updates of commit ee36267:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Security.Cryptography/CngAlgorithm.xml ✅Succeeded View
xml/System.Security.Cryptography/CngAlgorithmGroup.xml ✅Succeeded View
xml/System.Security.Cryptography/CngKey.xml ✅Succeeded View
xml/System.Security.Cryptography/CngKeyBlobFormat.xml ✅Succeeded View
xml/System.Security.Cryptography/CngKeyCreationParameters.xml ✅Succeeded View
xml/System.Security.Cryptography/CngProvider.xml ✅Succeeded View
xml/System.Security.Cryptography/CngUIPolicy.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@luizhlelis luizhlelis marked this pull request as ready for review October 26, 2021 13:00
@luizhlelis luizhlelis requested a review from a team as a code owner October 26, 2021 13:00
@bartonjs
Copy link
Member

bartonjs commented Nov 5, 2021

The technical aspect is correct, but I don't know about wording or style.

@gewarren ?

@gewarren
Copy link
Contributor

gewarren commented Nov 5, 2021

@bartonjs Should I also add these CNG APIs to this page? https://docs.microsoft.com/en-us/dotnet/core/compatibility/unsupported-apis

@bartonjs
Copy link
Member

bartonjs commented Nov 5, 2021

Yeah, that does seem good for consistency 😄 They only work on Windows, so in the parlance of that page they don't work on "Linux and macOS"

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit d88edb1 into dotnet:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Security Issues related to security practices for .NET developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Security.Cryptography. CngKey.Import doesn't work on Linux.
5 participants