Port new triple slash docs for .NET 7 Alpha [? - Nov '21] #7424

carlossanlop · 2021-11-24T17:02:53Z

No need to panic. I know it's a big PR but the majority of the changes are just EII messages in the remarks.

I split the changes in one commit per assembly to make it easier to review.

I'll try to submit monthly PRs to avoid having all the docs porting work right before we ship. cc @jeffhandley

Only 3 commits have actual new documentation, and need review from area owners:

System.Numerics - @tannergooding
System.Runtime.Intrinsics - @tannergooding
System.Text.Json - Largest chunk of actual new docs. - @layomia @eiriktsarpalis
System.Web - Largest commit, but it's mostly EII messages. - @Rick-Anderson

There are a few other assemblies with sprinkled individual docs.

@gewarren I also added the new docs the tool found in Microsoft.Build. Should I keep those? I kind of recall someone asking us not to modify their docs, but I can't find the issue/PR, or area owner.

xml/System.Web.UI.WebControls/MenuItemBinding.xml

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

gewarren

Adding my comments on the MSBuild imports.

xml/Microsoft.Build.Globbing/CompositeGlob.xml

xml/Microsoft.Build.Globbing/MSBuildGlob.xml

xml/Microsoft.Build.Logging/BinaryLogger.xml

xml/Microsoft.Build.Tasks/Copy.xml

xml/Microsoft.Build.Tasks/RoslynCodeTaskFactory.xml

xml/System.Numerics/Vector.xml

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

xml/Microsoft.Build.Globbing/MSBuildGlobWithGaps.xml

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

opbld31 · 2021-12-01T03:29:53Z

Docs Build status updates of commit c239961:

⚠️ Validation status: warnings

File	Status	Preview URL	Details
xml/System.Web.UI.WebControls/ListView.xml	⚠️Warning	View	Details
xml/Microsoft.Build.Construction/ProjectElement.xml	✅Succeeded	View
xml/Microsoft.Build.Framework/SdkReference.xml	✅Succeeded	View
xml/Microsoft.Build.Globbing/CompositeGlob.xml	✅Succeeded	View
xml/Microsoft.Build.Globbing/MSBuildGlob.xml	✅Succeeded	View
xml/Microsoft.Build.Globbing/MSBuildGlobWithGaps.xml	✅Succeeded	View
xml/Microsoft.Build.Graph/GraphBuildOptions.xml	✅Succeeded	View
xml/Microsoft.Build.Logging/BinaryLogger.xml	✅Succeeded	View
xml/Microsoft.Build.Logging/BuildEventArgsReader.xml	✅Succeeded	View
xml/Microsoft.Build.Logging/ProfilerLogger.xml	✅Succeeded	View
xml/Microsoft.Build.Tasks/CodeTaskFactory.xml	✅Succeeded	View
xml/Microsoft.Build.Tasks/Copy.xml	✅Succeeded	View
xml/Microsoft.Build.Tasks/DownloadFile.xml	✅Succeeded	View
xml/Microsoft.Build.Tasks/RoslynCodeTaskFactory.xml	✅Succeeded	View
xml/Microsoft.Build.Tasks/Unzip.xml	✅Succeeded	View
xml/Microsoft.Extensions.Configuration.EnvironmentVariables/EnvironmentVariablesConfigurationProvider.xml	✅Succeeded	View
xml/Microsoft.Extensions.Configuration/ConfigurationExtensions.xml	✅Succeeded	View
xml/Microsoft.Extensions.Primitives/StringValues.xml	✅Succeeded	View
xml/System.Activities.Presentation.Model/ModelItemCollection.xml	✅Succeeded	View
xml/System.Activities.Presentation.Model/ModelItemDictionary.xml	✅Succeeded	View
xml/System.Activities.Presentation.Model/ModelMemberCollection`2.xml	✅Succeeded	View
xml/System.Activities.Presentation.PropertyEditing/PropertyEntryCollection.xml	✅Succeeded	View
xml/System.Activities.Presentation.PropertyEditing/PropertyValueCollection.xml	✅Succeeded	View
xml/System.Activities.Presentation/ContextItemManager.xml	✅Succeeded	View
xml/System.Activities.Presentation/ServiceManager.xml	✅Succeeded	View
xml/System.Activities/ExecutionProperties.xml	✅Succeeded	View
xml/System.ComponentModel.Design.Serialization/DesignerSerializationManager.xml	✅Succeeded	View
xml/System.ComponentModel.Design/DesignerCollection.xml	✅Succeeded	View
xml/System.ComponentModel.Design/EventBindingService.xml	✅Succeeded	View
xml/System.Device.Location/GeoCoordinateWatcher.xml	✅Succeeded	View
xml/System.Dynamic/ExpandoObject.xml	✅Succeeded	View
xml/System.IO.Compression/BrotliStream.xml	✅Succeeded	View
xml/System.IdentityModel.Tokens/SecurityKeyIdentifier.xml	✅Succeeded	View
xml/System.Messaging/MessageEnumerator.xml	✅Succeeded	View
xml/System.Messaging/MessageQueueEnumerator.xml	✅Succeeded	View
xml/System.Numerics/Vector.xml	✅Succeeded	View
xml/System.Numerics/Vector2.xml	✅Succeeded	View
xml/System.Numerics/Vector3.xml	✅Succeeded	View
xml/System.Numerics/Vector4.xml	✅Succeeded	View
xml/System.Numerics/Vector`1.xml	✅Succeeded	View
xml/System.Resources.Extensions/DeserializingResourceReader.xml	✅Succeeded	View
xml/System.Resources/ResourceSet.xml	✅Succeeded	View
xml/System.Security.Cryptography/AsymmetricAlgorithm.xml	✅Succeeded	View
xml/System.Speech.Recognition/SemanticValue.xml	✅Succeeded	View
xml/System.Text.Json.Serialization.Metadata/JsonCollectionInfoValues`1.xml	✅Succeeded	View
xml/System.Text.Json.Serialization.Metadata/JsonMetadataServices.xml	✅Succeeded	View
xml/System.Text.Json.Serialization.Metadata/JsonObjectInfoValues`1.xml	✅Succeeded	View
xml/System.Text.Json.Serialization.Metadata/JsonParameterInfoValues.xml	✅Succeeded	View
xml/System.Text.Json.Serialization.Metadata/JsonPropertyInfoValues`1.xml	✅Succeeded	View
xml/System.Text.Json.Serialization.Metadata/JsonTypeInfo.xml	✅Succeeded	View

This comment lists only the first 50 files in the pull request.

xml/System.Web.UI.WebControls/ListView.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

gewarren

Looks perfect, thanks!

carlossanlop added 17 commits November 24, 2021 10:33

System

89ae851

System.Activities

b3485b1

System.ComponentModel

2fe331d

System.Device

1766dc5

System.Dynamic

47b8236

System.IdentityModel

32bc61d

System.IO.Compression

f0b3e2a

System.Messaging

aedd0cb

System.Numerics

c434bb6

System.Resources

d983d72

System.Runtime.Intrinsics

1eb200c

System.Security.Cryptography

0bf1f6f

System.Speech

31f7dc6

System.Text.Json

18b9a39

System.Transactions

fef2cf3

System.Web

868c8ad

System.Workflow

8cb3794

carlossanlop requested a review from gewarren November 24, 2021 17:03

ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Nov 24, 2021

carlossanlop self-assigned this Nov 24, 2021

carlossanlop added 8 commits November 24, 2021 12:05

Microsoft.Extensions.Configuration

79d6463

Microsoft.Extension.Primitives

d236d33

Microsoft.Build.Construction

471c69b

Microsoft.Build.Framework

ba0802a

Microsoft.Build.Globbing

54c6b38

Microsoft.Build.Graph

ba13e0f

Microsoft.Build.Logging

9735c94

Microsoft.Build.Tasks

5619754

carlossanlop marked this pull request as ready for review November 24, 2021 18:17

carlossanlop requested a review from HongGit as a code owner November 24, 2021 18:17

carlossanlop commented Nov 30, 2021

View reviewed changes

xml/System.Web.UI.WebControls/MenuItemBinding.xml Outdated Show resolved Hide resolved

Suggestions by gewarren

acc502b

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

This comment has been minimized.

Sign in to view

gewarren reviewed Nov 30, 2021

View reviewed changes