Preserve view moniker #7472
Merged
Preserve view moniker #7472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs Build status updates of commit a825641: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
kouvel
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@huangmin-ms @TianqiZhang This seems to be a feature/bug that if an overload isn't available in the selected moniker, the link falls back to the generic overloads page. A possible design change would be to see if the overload is available in any other version, and if so, redirect to the most recent version that contains that moniker.
Preview of fix: https://review.docs.microsoft.com/en-us/dotnet/api/system.threading.eventwaithandle.openexisting?view=net-6.0&branch=pr-en-us-7472#System_Threading_EventWaitHandle_OpenExisting_System_String_