Skip to content

Remove version-dependant marker for ArgumentException thrown by Copy methods #7476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

miloszkukla
Copy link
Contributor

The code for .NET 6: https://source.dot.net/#System.Private.CoreLib/File.cs,57 indicates that ArgumentException will be thrown for zero-lenght strings so the information seems to be invalid. Other methods in this class also contain this information but I didn't check whether it's a case for them.

…methods

The code for .NET 6: https://source.dot.net/#System.Private.CoreLib/File.cs,57 indicates that ArgumentException will be thrown for zero-lenght strings so the information seems to be invalid. Other methods in this class also contain this information but I didn't check whether it's a case for them.
@miloszkukla miloszkukla requested a review from a team as a code owner December 9, 2021 07:28
@ghost ghost added the area-System.IO label Dec 9, 2021
@ghost
Copy link

ghost commented Dec 9, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

The code for .NET 6: https://source.dot.net/#System.Private.CoreLib/File.cs,57 indicates that ArgumentException will be thrown for zero-lenght strings so the information seems to be invalid. Other methods in this class also contain this information but I didn't check whether it's a case for them.

Author: miloszkukla
Assignees: -
Labels:

area-System.IO

Milestone: -

@opbld33
Copy link

opbld33 commented Dec 9, 2021

Docs Build status updates of commit 27197cf:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/File.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @miloszkukla !

@adamsitnik adamsitnik merged commit 69b31f0 into dotnet:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants