Skip to content

ThrowIfCancellationRequested doesn't throw ObjectDisposedException #7555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Jan 6, 2022

Summary

CancellationToken.ThrowIfCancellationRequested() doesn't throw ObjectDisposedException ever

Fixes #7497

@buyaa-n buyaa-n requested a review from kouvel as a code owner January 6, 2022 01:53
@ghost
Copy link

ghost commented Jan 6, 2022

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

CancellationToken.ThrowIfCancellationRequested() doesn't throw ObjectDisposedException ever

Fixes #7497

Author: buyaa-n
Assignees: -
Labels:

area-System.Threading.Tasks

Milestone: -

@opbld32
Copy link

opbld32 commented Jan 6, 2022

Docs Build status updates of commit 5a09f18:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Threading/CancellationToken.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@buyaa-n buyaa-n merged commit 88e67fe into dotnet:main Jan 6, 2022
@buyaa-n buyaa-n deleted the remove-exception branch January 6, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CancellationToken ThrowIfCancellationRequested exceptions in documentation seems incorrect
3 participants