-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Document exceptions on async Socket methods. #8525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/ncl |
Learn Build status updates of commit d08cc96:
|
File | Status | Preview URL | Details |
---|---|---|---|
xml/System.Net.Sockets/SocketTaskExtensions.xml | View | Details | |
xml/System.Net.Sockets/Socket.xml | ✅Succeeded | View | |
xml/System.Net/IPEndPoint.xml | ✅Succeeded | View |
xml/System.Net.Sockets/SocketTaskExtensions.xml
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Net.Sockets.SocketTaskExtension.AcceptAsync(System.Net.Sockets)'.
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Net.Sockets.SocketTaskExtensions.AcceptAsync(System.Net.Sockets.Socket, System.Net.Sockets.Socket)'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
4a4e019
to
d08cc96
Compare
Learn Build status updates of commit 4a4e019:
|
File | Status | Preview URL | Details |
---|---|---|---|
xml/System.Net.Sockets/SocketTaskExtensions.xml | View | Details | |
xml/System.Net.Http/WinHttpHandler.xml | ✅Succeeded | View | |
xml/System.Net.Sockets/Socket.xml | ✅Succeeded | View | |
xml/System.Net/IPEndPoint.xml | ✅Succeeded | View |
xml/System.Net.Sockets/SocketTaskExtensions.xml
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Net.Sockets.SocketTaskExtension.AcceptAsync(System.Net.Sockets)'.
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Net.Sockets.SocketTaskExtensions.AcceptAsync(System.Net.Sockets.Socket, System.Net.Sockets.Socket)'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit d08cc96:
|
File | Status | Preview URL | Details |
---|---|---|---|
xml/System.Net.Sockets/SocketTaskExtensions.xml | View | Details | |
xml/System.Net.Sockets/Socket.xml | ✅Succeeded | View | |
xml/System.Net/IPEndPoint.xml | ✅Succeeded | View |
xml/System.Net.Sockets/SocketTaskExtensions.xml
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Net.Sockets.SocketTaskExtension.AcceptAsync(System.Net.Sockets)'.
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Net.Sockets.SocketTaskExtensions.AcceptAsync(System.Net.Sockets.Socket, System.Net.Sockets.Socket)'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be consistent with NotSupportedException
, otherwise looks good.
We should also review & fix the sync and the Begin*
methods, but I will do that together with #5045, once this PR is merged.
Learn Build status updates of commit 8533200:
|
File | Status | Preview URL | Details |
---|---|---|---|
xml/System.Net.Sockets/SocketTaskExtensions.xml | View | Details | |
xml/System.Net.Sockets/Socket.xml | ✅Succeeded | View | |
xml/System.Net/IPEndPoint.xml | ✅Succeeded | View |
xml/System.Net.Sockets/SocketTaskExtensions.xml
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Net.Sockets.SocketTaskExtension.AcceptAsync(System.Net.Sockets)'.
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Net.Sockets.SocketTaskExtensions.AcceptAsync(System.Net.Sockets.Socket, System.Net.Sockets.Socket)'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Learn Build status updates of commit f3280b7: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1350.