Skip to content

Add remarks about stored exceptions #8748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add remarks about stored exceptions #8748

wants to merge 2 commits into from

Conversation

gewarren
Copy link
Contributor

Contributes to #7840

@ghost ghost assigned gewarren Dec 29, 2022
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Dec 29, 2022
@learn-build-service-prod
Copy link

Learn Build status updates of commit 1784338:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Caching.Distributed/DistributedCacheExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Caching.Distributed/IDistributedCache.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Caching.Distributed/MemoryDistributedCache.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Caching.Redis/RedisCache.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Caching.SqlServer/SqlServerCache.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Caching.StackExchangeRedis/RedisCache.xml ⚠️Warning View Details
xml/Microsoft.Extensions.DependencyInjection/AsyncServiceScope.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Diagnostics.HealthChecks/HealthCheckService.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Diagnostics.HealthChecks/IHealthCheck.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Diagnostics.HealthChecks/IHealthCheckPublisher.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting.Internal/ConsoleLifetime.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting.Systemd/SystemdLifetime.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting.WindowsServices/WindowsServiceLifetime.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting/BackgroundService.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting/HostingAbstractionsHostBuilderExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting/HostingAbstractionsHostExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting/IHost.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting/IHostedService.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting/IHostLifetime.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http/PolicyHttpMessageHandler.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/AzureBlobSink.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BatchingLoggerProvider.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BlobAppendReferenceWrapper.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BlobLoggerProvider.xml ⚠️Warning View Details

This comment lists only the first 25 files in the pull request.

xml/Microsoft.Extensions.Caching.Distributed/DistributedCacheExtensions.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.DistributedCacheExtensions.GetString(Microsoft.Extensions.Caching.Distributed.IDistributedCache,System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.DistributedCacheExtensions.Set(Microsoft.Extensions.Caching.Distributed.IDistributedCache,System.String,System.Byte[],System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.DistributedCacheExtensions.SetString(Microsoft.Extensions.Caching.Distributed.IDistributedCache,System.String,System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.DistributedCacheExtensions.SetString(Microsoft.Extensions.Caching.Distributed.IDistributedCache,System.String,System.String,Microsoft.Extensions.Caching.Distributed.DistributedCacheEntryOptions,System.Threading.CancellationToken)'.

xml/Microsoft.Extensions.Caching.Distributed/IDistributedCache.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.IDistributedCache.Refresh(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.IDistributedCache.Set(System.String,System.Byte[],Microsoft.Extensions.Caching.Distributed.DistributedCacheEntryOptions,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.IDistributedCache.Get(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.IDistributedCache.Remove(System.String,System.Threading.CancellationToken)'.

xml/Microsoft.Extensions.Caching.Distributed/MemoryDistributedCache.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.MemoryDistributedCache.Get(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.MemoryDistributedCache.Refresh(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.MemoryDistributedCache.Remove(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Distributed.MemoryDistributedCache.Set(System.String,System.Byte[],Microsoft.Extensions.Caching.Distributed.DistributedCacheEntryOptions,System.Threading.CancellationToken)'.

xml/Microsoft.Extensions.Caching.Redis/RedisCache.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Redis.RedisCache.Get(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Redis.RedisCache.Refresh(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Redis.RedisCache.Set(System.String,System.Byte[],Microsoft.Extensions.Caching.Distributed.DistributedCacheEntryOptions,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.Redis.RedisCache.Remove(System.String,System.Threading.CancellationToken)'.

xml/Microsoft.Extensions.Caching.SqlServer/SqlServerCache.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.SqlServer.SqlServerCache.Refresh(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.SqlServer.SqlServerCache.Set(System.String,System.Byte[],Microsoft.Extensions.Caching.Distributed.DistributedCacheEntryOptions,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.SqlServer.SqlServerCache.Get(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.SqlServer.SqlServerCache.Remove(System.String,System.Threading.CancellationToken)'.

xml/Microsoft.Extensions.Caching.StackExchangeRedis/RedisCache.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.StackExchangeRedis.RedisCache.Refresh(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.StackExchangeRedis.RedisCache.Set(System.String,System.Byte[],Microsoft.Extensions.Caching.Distributed.DistributedCacheEntryOptions,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.StackExchangeRedis.RedisCache.Get(System.String,System.Threading.CancellationToken)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Caching.StackExchangeRedis.RedisCache.Remove(System.String,System.Threading.CancellationToken)'.

xml/Microsoft.Extensions.DependencyInjection/AsyncServiceScope.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.DependencyInjection.ServiceScope.Dispose'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren closed this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merriemcgaw merriemcgaw Awaiting requested review from merriemcgaw merriemcgaw will be requested when the pull request is marked ready for review merriemcgaw is a code owner

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne JeremyKuhne will be requested when the pull request is marked ready for review JeremyKuhne is a code owner

@Rick-Anderson Rick-Anderson Awaiting requested review from Rick-Anderson Rick-Anderson will be requested when the pull request is marked ready for review Rick-Anderson is a code owner

@kouvel kouvel Awaiting requested review from kouvel kouvel will be requested when the pull request is marked ready for review kouvel is a code owner

@HongGit HongGit Awaiting requested review from HongGit HongGit will be requested when the pull request is marked ready for review HongGit is a code owner

@mconnew mconnew Awaiting requested review from mconnew mconnew will be requested when the pull request is marked ready for review mconnew is a code owner

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT AaronRobinsonMSFT will be requested when the pull request is marked ready for review AaronRobinsonMSFT is a code owner

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky jkoritzinsky will be requested when the pull request is marked ready for review jkoritzinsky is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 will be requested when the pull request is marked ready for review halter73 is a code owner

@David-Engel David-Engel Awaiting requested review from David-Engel David-Engel will be requested when the pull request is marked ready for review David-Engel is a code owner

@cheenamalhotra cheenamalhotra Awaiting requested review from cheenamalhotra cheenamalhotra will be requested when the pull request is marked ready for review cheenamalhotra is a code owner

Assignees

@gewarren gewarren

Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gewarren