-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add OperationCanceledException exceptions automatically #8776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Thanks, @gewarren, but I'm confused. Typically |
@stephentoub Yes, I agree with that, but in my notes from our meeting in November this was one of the things we decided to do as a stop-gap measure. I'm happy to close this, or perhaps we can still use the
|
Did we discuss just doing that for all the exceptions, e.g. copyimg from the sync counterpart and adding that verbiage in the exception tag itself? I wonder if that'd be sufficient to just call this whole thing done. |
@stephentoub We didn't discuss that, but it seems like a good idea to me. Thoughts @antonfirsov @BillWagner? We could run the tool periodically to catch any new exceptions that were added to the synchronous method. |
I like this plan. It keeps us moving forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement. Let's
Converted to draft PR until I add in the extra text on the end. |
Learn Build status updates of commit 01e30fc: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Closing and replacing due to too many conflicts. |
Used a utility I wrote to automatically add
OperationCanceledException
exceptions with reason "The cancellation token was canceled" to methods that accept aCancellationToken
parameter.Example preview.
Contributes to #7840.
Replaces #8745.
cc @stephentoub