Skip to content

Fix up operation canceled exceptions #9367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix up operation canceled exceptions #9367

merged 2 commits into from
Oct 4, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 3, 2023

Users should catch OperationCanceledException instead of TaskCanceledException (see #9362 (comment)).

@gewarren gewarren requested a review from a team as a code owner October 3, 2023 23:46
@ghost ghost assigned gewarren Oct 3, 2023
@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod
Copy link

Learn Build status updates of commit 567e18c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/ConfiguredTaskAwaitable`1+ConfiguredTaskAwaiter.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/ConfiguredTaskAwaitable+ConfiguredTaskAwaiter.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/TaskAwaiter.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/TaskAwaiter`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit fb79c4c into dotnet:main Oct 4, 2023
@gewarren gewarren deleted the comiplerservices-opcanceled branch October 4, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@gewarren gewarren

Labels
area-System.Runtime.CompilerServices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner