Skip to content

Extract long remarks for System.Globalization #9526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Dec 28, 2023

Hide whitespace changes in diff.

Merge this after dotnet/docs#38912.

(Snippets 5000 error is due to missing projects but I don't plan to address that in this PR.)

@ghost ghost assigned gewarren Dec 28, 2023
@ghost
Copy link

ghost commented Dec 28, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Hide whitespace changes in diff.

Author: gewarren
Assignees: gewarren
Labels:

area-System.Globalization

Milestone: -

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@gewarren gewarren marked this pull request as ready for review January 2, 2024 17:08
@gewarren gewarren requested a review from a team as a code owner January 2, 2024 17:08
@gewarren gewarren closed this Jan 2, 2024
@gewarren gewarren reopened this Jan 2, 2024
Copy link

Learn Build status updates of commit 9f5c55a:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Globalization/CompareInfo.xml ⚠️Warning View Details
xml/System.Globalization/CultureAndRegionInfoBuilder.xml ⚠️Warning View Details
xml/System.Globalization/CultureInfo.xml ⚠️Warning View Details
xml/System.Globalization/DateTimeFormatInfo.xml ⚠️Warning View Details
xml/System.Globalization/NumberFormatInfo.xml ⚠️Warning View Details
xml/System.Globalization/RegionInfo.xml ⚠️Warning View Details
xml/System.Globalization/SortVersion.xml ⚠️Warning View Details
snippets/csharp/System.Globalization/CultureInfo/Overview/appdomainex1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/asyncculture1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/asyncculture2.cs ✅Succeeded
snippets/csharp/System.Globalization/CultureInfo/Overview/asyncculture3.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/asyncculture4.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/Change1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/ChangeUI1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/Current1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/CurrentUI1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/defaultthread1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/GetCultures1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/perthread1.cs ✅Succeeded
snippets/csharp/System.Globalization/CultureInfo/Overview/project.csproj ✅Succeeded
snippets/csharp/System.Globalization/CultureInfo/Overview/setthreads1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/Overview/spanishspain.cs ✅Succeeded View
snippets/csharp/System.Globalization/DateTimeFormatInfo/Overview/create1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/DateTimeFormatInfo/Overview/create2.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/DateTimeFormatInfo/Overview/example1.cs ✅Succeeded n/a (file deleted or renamed)

This comment lists only the first 25 files in the pull request.

xml/System.Globalization/CompareInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/CultureAndRegionInfoBuilder.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/CultureInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/DateTimeFormatInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/NumberFormatInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/RegionInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/SortVersion.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren merged commit fceb726 into dotnet:main Jan 2, 2024
@gewarren gewarren deleted the remarks-system.globalization branch January 2, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants