Update internal Dockerfile templates to support managed identity OAuth token #6472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
reviewed
Jun 3, 2025
lbussell
commented
Jun 3, 2025
...tTests/VerifyInternalDockerfilesOutput/aspnet-10.0-trixie-slim-amd64-Dockerfile.approved.txt
Outdated
Show resolved
Hide resolved
f8912f5 to
f1f5aa6
Compare
b1efa67 to
7824dfa
Compare
|
Yes, this PR touches all Dockerfiles because all of them had extra whitespace. I can separate the whitespace fix out into a separate PR if necessary. |
mthalman
approved these changes
Jun 10, 2025
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/dotnet/dotnet-docker-internal/issues/7413
The internal Dockerfile templates have been updated to use the new staging storage account. We will use managed identity to access it instead of the azure pipelines system access token.
The existing internal Dockerfile templates did not work with managed identity tokens, so this PR also contains updates to the templates and download commands that are required.