Add update-dependencies support for resolving .NET build manifest from pipeline artifacts #6502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbussell
commented
Jun 25, 2025
Comment on lines
39
to
49
| public HttpClient GetAuthenticatedHttpClient() | ||
| { | ||
| // Create an HttpClient that uses the Azure Developer CLI credential for authentication. | ||
| var httpClient = new HttpClient(); | ||
| var header = new AuthenticationHeaderValue( | ||
| "Basic", | ||
| Convert.ToBase64String(Encoding.ASCII.GetBytes(string.Format("{0}:{1}", "", _accessToken.Value)))); | ||
| httpClient.DefaultRequestHeaders.Authorization = header; | ||
|
|
||
| return httpClient; | ||
| } |
There was a problem hiding this comment.
I know doing HttpClients this way is bad. I'll come back and fix it in a bit.
mthalman
reviewed
Jun 26, 2025
mthalman
approved these changes
Jun 26, 2025
mthalman
approved these changes
Jun 26, 2025
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
Jul 7, 2025
…m pipeline artifacts (dotnet#6502)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6484
This PR allows you to choose between resolving the .NET Build Manifest from either the staging storage account or the staging pipeline artifacts, based on whether you passed the CLI option
--staging-storage-account. This allows devs to target staged builds from their local machine without needing access to the production staging storage account.