Skip to content

Clean up more Dockerfile templates and optimize removing/extracting multiple files #6506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

Clean up more Dockerfile templates and optimize removing/extracting multiple files #6506

merged 2 commits into from
Jun 30, 2025

Conversation

lbussell
Copy link
Contributor

Summary

  • Decouple templates for extracting files cleaning up those files, so that we can have better control over how and when files are cleaned up
  • Optimize removing multiple files by calling rm once instead of twice
  • Combine extract-tarball and extract-zip files because they were similar
  • Removed Dockerfile.linux.download-validate-file because it wasn't providing enough useful abstraction
  • Fix extra whitespace in some Dockerfiles
  • Minor fixes/tweaks to handling online shas which I'm working on separately

Related

@lbussell lbussell requested review from wiktork and a team as code owners June 27, 2025 15:50
@lbussell lbussell mentioned this pull request Jun 27, 2025
Merged
@lbussell lbussell merged commit 78b89a4 into dotnet:nightly Jun 30, 2025
114 checks passed
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Jul 7, 2025
@lbussell
Clean up more Dockerfile templates and optimize removing/extracting m…
fecc522 
…ultiple files (dotnet#6506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthalman mthalman mthalman approved these changes

@wiktork wiktork Awaiting requested review from wiktork wiktork is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbussell @mthalman