Skip to content

Use full build versions when updating dependencies for pre-release .NET builds #6518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell commented Jul 3, 2025

Summary of changes:

  • Use separate build and product versions for pre-release images. Previously, we would set both build-version and product-version (in manifest.versions.json) to the product version for stable builds. But for pre-release builds, we need to set the build version explicitly or else the Dockerfile templates have no way to construct the correct URL. This is because in the staging storage account, stable versions of .NET still have the full build version in their blob container name. This makes sense in case multiple versions of the same stable version need to be staged.
  • Go back to using ReleaseConfig instead of BuildManifest to resolve product versions. Reasoning:
    • We are no longer concerned with reading *.sha512 files which were listed in the BuildManifest
    • It's easier to read the build vs. product versions directly from ReleaseConfig. BuildManifest lists all the artifacts that were published, but to get the build version we would still have to parse it out of a storage account URL or download and read a second artifact. We can just get everything from the ReleaseConfig instead.
  • Only get pre-release build versions from pipeline artifacts, not the storage account. I know that code is relatively new, but the pipeline method is just simpler for now. Now that we use online shas, I think this decision is less impactful. We can also always add the storage account code back from version control if we need it.

@lbussell lbussell requested a review from a team as a code owner July 3, 2025 22:26
@lbussell lbussell changed the title Use full build versions for pre-release .NET builds Use full build versions when updating dependencies for pre-release .NET builds Jul 3, 2025
@lbussell lbussell merged commit eedaa4c into dotnet:nightly Jul 7, 2025
114 checks passed
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants