Skip to content

Port the rest of the cohosting endpoints to VS Code #8249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2025
Merged

Port the rest of the cohosting endpoints to VS Code #8249

merged 5 commits into from
May 6, 2025

Conversation

davidwengier
Copy link
Member

@davidwengier davidwengier commented May 5, 2025 •
edited
Loading

This is everything we currently support.

Razor side: dotnet/razor#11815
Part of dotnet/razor#11759

Now including bumps for Roslyn:
View Complete Diff of Changes

  • Move RestoreUseStaticGraphEvaluation setting inside repo (#78429) (PR: #78429)
  • Adjust LocalBinderFactory.VisitInvocationExpression to handle attributes on extension parameter (#78399) (PR: #78399)
  • Exclude EditorFeatures from rebuild check (#78437) (PR: #78437)
  • Ensure hover markdown for supported platforms uses non-breaking spaces for indentation (#78405) (PR: #78405)
  • Change O(n) + O(lg n) search in SolutionState.SortedProjectStates to just O(lg n) (#78427) (PR: #78427)
  • Fix syntax tree creation when modifying source generated documents (#78343) (PR: #78343)
  • Revert back to scouting queue (#78424) (PR: #78424)
  • Precursor work to merge EditorFeatures.WPF into EditorFeatures. (#78308) (PR: #78308)
  • Skip generate analyzer documentation to unblock ci (#78412) (PR: #78412)
  • Switch to non-scouting queue to unblock CI (#78407) (PR: #78407)
  • Implement workaround for missing ValueTuple in remote debugger (#78393) (PR: #78393)

and Razor:
View Complete Diff of Changes

  • Port remaining cohosting endpoints to VS Code (#11815) (PR: #11815)
  • Fix cohost semantic tokens in VS Code (#11816) (PR: #11816)
  • Fix some hardcoded values in cohosting (#11817) (PR: #11817)
  • Add new shared SelectXXXAsArray helpers (#11796) (PR: #11796)

@davidwengier davidwengier requested review from a team as code owners May 5, 2025 04:32
@davidwengier davidwengier mentioned this pull request May 5, 2025
Merged
davidwengier added a commit to dotnet/razor that referenced this pull request May 5, 2025
@davidwengier
Port remaining cohosting endpoints to VS Code (#11815)
9e23fe8 
This is the rest of them!

C# extension side: dotnet/vscode-csharp#8249
Part of #11759
dibarbet
dibarbet approved these changes May 6, 2025
View reviewed changes
@davidwengier @dibarbet
Apply suggestions from code review
136ed70 
Co-authored-by: David Barbet <dibarbet@gmail.com>
@davidwengier davidwengier merged commit d8c8cd0 into dotnet:main May 6, 2025
24 checks passed
@davidwengier davidwengier deleted the MoreCohosting branch May 6, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@ryzngard ryzngard ryzngard approved these changes

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwengier @DustinCampbell @ryzngard @dibarbet