Add FAR across razor and cs files #8250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
commented
May 6, 2025
dibarbet
reviewed
May 6, 2025
dibarbet
approved these changes
May 8, 2025
|
|
||
| await integrationHelpers.waitForExpectedResult<vscode.Location[]>( | ||
| async () => | ||
| await vscode.commands.executeCommand( |
There was a problem hiding this comment.
is this done in waitForExpectedResults in order to retry? Generally awaiting the command should return the results
There was a problem hiding this comment.
Yea, it's just for the retry logic. Since this now is actually using project information instead of misc project it can happen before syncing csharp if the test runs too fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames tests to reference instead of definition, but I kept the definition test there since it's sort of under the umbrella of that and naming is hard.
Adds a new test that uses a code behind to find references that exist in both cs and razor.
Found an issue with why some tests are hard to write. I added documentation of my findings but haven't found a good solution, just a workaround to avoid getting into that state. We'll see how bad that gets because it may mean that tests will race against eachother. It also may mean my fix isn't really a fix at all and we'll need something better...