Skip to content

Add option 'enableFileBasedPrograms' #8253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2025
Merged

Add option 'enableFileBasedPrograms' #8253

merged 3 commits into from
May 13, 2025

Conversation

RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson requested a review from a team as a code owner May 6, 2025 19:01
@RikkiGibson RikkiGibson mentioned this pull request May 6, 2025
Closed
6 tasks
@RikkiGibson
Copy link
Member Author

I can see the CI failure is related to my change, but, I don't know how to track it down or resolve it.

starting node /home/vsts/work/1/s/node_modules/@vscode/vsce/vsce package -o /home/vsts/work/1/s/vsix/csharp-linux-x64-2.77.18-gbc0ac75356.vsix --target linux-x64 --pre-release --baseContentUrl https://github.com/dotnet/vscode-csharp
 ERROR  No translation found for %configuration.dotnet.projects.enableFileBasedPrograms%
[19:05:04] 'vsix:release:package:linux:linux-x64' errored after 33 s
[19:05:04] Error: Failed to create package linux-x64. Error: '/home/vsts/work/1/s/node_modules/@vscode/vsce/vsce package -o /home/vsts/work/1/s/vsix/csharp-linux-x64-2.77.18-gbc0ac75356.vsix --target linux-x64 --pre-release --baseContentUrl https://github.com/dotnet/vscode-csharp' failed with code 1.
    at createPackageAsync (/home/vsts/work/1/s/tasks/vsceTasks.ts:50:15)
    at buildVsix (/home/vsts/work/1/s/tasks/offlinePackagingTasks.ts:393:25)
    at doPackageOffline (/home/vsts/work/1/s/tasks/offlinePackagingTasks.ts:362:13)
    at /home/vsts/work/1/s/tasks/offlinePackagingTasks.ts:126:9
---
    at doPackageOffline (/home/vsts/work/1/s/tasks/offlinePackagingTasks.ts:368:15)
    at /home/vsts/work/1/s/tasks/offlinePackagingTasks.ts:126:9
[19:05:04] 'vsix:release:package:linux' errored after 33 s

Perhaps the server needs to be updated first? I just have no clue how to track down the process which is verifying the set of options here. @jasonmalinowski

@dibarbet
Copy link
Member

dibarbet commented May 6, 2025

@RikkiGibson you need to update the localization file to include the new string - https://github.com/dotnet/vscode-csharp/blob/main/package.nls.json

@dibarbet
Copy link
Member

dibarbet commented May 6, 2025

However - you also need to do some server side changes if you want to read it on the server. For example take a look at dotnet/roslyn#75224 and #7381

The client side needs to be combined with a server side PR exposing the option via LSP.

@RikkiGibson
Copy link
Member Author

Thanks for the guidance @dibarbet. I believe I have the prerequisite changes ready to go on the LSP side in my PR dotnet/roslyn#78208.

jasonmalinowski
jasonmalinowski reviewed May 6, 2025
View reviewed changes
@RikkiGibson RikkiGibson mentioned this pull request May 7, 2025
Merged
@RikkiGibson RikkiGibson merged commit cad4b0f into main May 13, 2025
24 checks passed
@RikkiGibson RikkiGibson deleted the dev/rigibson/add-optout-flag branch May 13, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RikkiGibson @dibarbet @jasonmalinowski @JoeRobich