Update Roslyn 5.0.0-1.25256.5 (#8254) #8255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
approved these changes
May 6, 2025
davidwengier
reviewed
May 7, 2025
| @@ -15,6 +15,9 @@ | |||
| * Fix syntax tree creation when modifying source generated documents (#78343) (PR: [#78343](https://github.com/dotnet/roslyn/pull/78343)) | |||
|
|
|||
| # 2.76.x | |||
| * Bump Roslyn to 5.0.0-1.25256.5 (PR: [#8254](https://github.com/dotnet/vscode-csharp/pull/8254)) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
So since the same bump did merge into prerelease, it is correct to list it under 2.76.x. I think removing the roslyn bump from 2.77.x makes sense unless you are also going to insert a new Roslyn in #8259.
There was a problem hiding this comment.
Nope, not planning on it. So to confirm, the two commits mentioned in the bump in 2.77 are in this build too? If so, I'll move those down in the changelog too
There was a problem hiding this comment.
yeah, we're merging changes into prerelease. There is going to be one more merge into prerelease as well, so fine to remove the roslyn bumps from the 2.77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.